Prefer \n to \r\n

pull/310/head
Frostebite 2021-12-29 14:35:13 +00:00
parent 4c38ffd178
commit 156a9de7eb
7 changed files with 27 additions and 13 deletions

18
dist/index.js vendored
View File

@ -411,7 +411,7 @@ class CLI {
const program = new commander_ts_1.Command();
program.version('0.0.1');
const properties = Object.getOwnPropertyNames(__1.Input);
core.info(`\r\n`);
core.info(`\n`);
core.info(`INPUT:`);
for (const element of properties) {
// TODO pull description from action.yml
@ -420,7 +420,7 @@ class CLI {
core.info(`${element} ${__1.Input[element]}`);
}
}
core.info(`\r\n`);
core.info(`\n`);
program.option('-m, --mode <mode>', 'cli or default');
program.parse(process.argv);
return program.opts();
@ -565,11 +565,11 @@ class CloudRunnerAgentSystem {
let output = '';
const child = child_process_1.exec(command, (error, stdout, stderr) => {
if (error) {
cloud_runner_logger_1.default.logCli(`[ERROR] ${error.message}`);
cloud_runner_logger_1.default.logCliError(`${error.message}`);
throw new Error(error.toString());
}
if (stderr) {
cloud_runner_logger_1.default.logCli(`[DIAGNOSTIC] ${stderr.toString()}`);
cloud_runner_logger_1.default.logCliDiagnostic(`${stderr.toString()}`);
return;
}
const outputChunk = `${stdout}`;
@ -1339,7 +1339,7 @@ class AWSTaskRunner {
}
message = `[${cloud_runner_statics_1.CloudRunnerStatics.logPrefix}] ${message}`;
if (cloud_runner_state_1.CloudRunnerState.buildParams.logToFile) {
fs_1.default.appendFileSync(`${cloud_runner_state_1.CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\r\n`);
fs_1.default.appendFileSync(`${cloud_runner_state_1.CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\n`);
}
cloud_runner_logger_1.default.log(message);
}
@ -2036,7 +2036,7 @@ class KubernetesLogging {
let message = chunk.toString();
message = `[${cloud_runner_statics_1.CloudRunnerStatics.logPrefix}] ${message}`;
if (cloud_runner_state_1.CloudRunnerState.buildParams.logToFile) {
fs_1.default.appendFileSync(`${cloud_runner_state_1.CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\r\n`);
fs_1.default.appendFileSync(`${cloud_runner_state_1.CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\n`);
}
logCallback(message);
next();
@ -2448,6 +2448,12 @@ class CloudRunnerLogger {
static logCli(message) {
CloudRunnerLogger.log(`[Client] ${message}`);
}
static logCliError(message) {
CloudRunnerLogger.log(`[Client][Error] ${message}`);
}
static logCliDiagnostic(message) {
CloudRunnerLogger.log(`[Client][Diagnostic] ${message}`);
}
static logLine(message) {
core.info(`${message}\n`);
}

2
dist/index.js.map vendored

File diff suppressed because one or more lines are too long

View File

@ -32,7 +32,7 @@ export class CLI {
const program = new Command();
program.version('0.0.1');
const properties = Object.getOwnPropertyNames(Input);
core.info(`\r\n`);
core.info(`\n`);
core.info(`INPUT:`);
for (const element of properties) {
// TODO pull description from action.yml
@ -41,7 +41,7 @@ export class CLI {
core.info(`${element} ${Input[element]}`);
}
}
core.info(`\r\n`);
core.info(`\n`);
program.option('-m, --mode <mode>', 'cli or default');
program.parse(process.argv);

View File

@ -8,11 +8,11 @@ export class CloudRunnerAgentSystem {
let output = '';
const child = exec(command, (error, stdout, stderr) => {
if (error) {
CloudRunnerLogger.logCli(`[ERROR] ${error.message}`);
CloudRunnerLogger.logCliError(`${error.message}`);
throw new Error(error.toString());
}
if (stderr) {
CloudRunnerLogger.logCli(`[DIAGNOSTIC] ${stderr.toString()}`);
CloudRunnerLogger.logCliDiagnostic(`${stderr.toString()}`);
return;
}
const outputChunk = `${stdout}`;

View File

@ -181,7 +181,7 @@ class AWSTaskRunner {
}
message = `[${CloudRunnerStatics.logPrefix}] ${message}`;
if (CloudRunnerState.buildParams.logToFile) {
fs.appendFileSync(`${CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\r\n`);
fs.appendFileSync(`${CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\n`);
}
CloudRunnerLogger.log(message);
}

View File

@ -22,7 +22,7 @@ class KubernetesLogging {
let message = chunk.toString();
message = `[${CloudRunnerStatics.logPrefix}] ${message}`;
if (CloudRunnerState.buildParams.logToFile) {
fs.appendFileSync(`${CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\r\n`);
fs.appendFileSync(`${CloudRunnerState.buildGuid}-outputfile.txt`, `${message}\n`);
}
logCallback(message);
next();

View File

@ -17,6 +17,14 @@ class CloudRunnerLogger {
CloudRunnerLogger.log(`[Client] ${message}`);
}
public static logCliError(message: string) {
CloudRunnerLogger.log(`[Client][Error] ${message}`);
}
public static logCliDiagnostic(message: string) {
CloudRunnerLogger.log(`[Client][Diagnostic] ${message}`);
}
public static logLine(message: string) {
core.info(`${message}\n`);
}