better named tests and log local-docker params

dist/index.js

@@ -4887,7 +4887,7 @@ class BuildAutomationWorkflow {
                 cloud_runner_logger_1.default.logLine('Starting build automation job');
                 // eslint-disable-next-line no-unused-vars
                 const workspace = (yield shared_workspace_locking_1.default.GetLockedWorkspace()) || cloud_runner_1.default.buildParameters.buildGuid;
-                output += yield cloud_runner_1.default.Provider.runTask(cloud_runner_1.default.buildParameters.buildGuid, baseImage.toString(), BuildAutomationWorkflow.BuildWorkflow, `/${cloud_runner_folders_1.CloudRunnerFolders.buildVolumeFolder}`, `/${cloud_runner_folders_1.CloudRunnerFolders.buildVolumeFolder}/`, [...cloud_runner_1.default.cloudRunnerEnvironmentVariables, ...cloudRunnerStepState.environment], [...cloud_runner_1.default.defaultSecrets, ...cloudRunnerStepState.secrets]);
+                output += yield cloud_runner_1.default.Provider.runTask(cloud_runner_1.default.buildParameters.buildGuid, baseImage.toString(), BuildAutomationWorkflow.BuildWorkflow, `/${cloud_runner_folders_1.CloudRunnerFolders.buildVolumeFolder}`, `/${cloud_runner_folders_1.CloudRunnerFolders.buildVolumeFolder}/`, cloudRunnerStepState.environment, cloudRunnerStepState.secrets);
                 if (!cloud_runner_1.default.buildParameters.isCliMode)
                     core.endGroup();
                 cloud_runner_logger_1.default.logWithTime('Build time');

src/model/cloud-runner/tests/cloud-runner-environment-serializer.test.ts

@@ -0,0 +1,49 @@
+import { BuildParameters } from '../..';
+import { TaskParameterSerializer } from '../services/task-parameter-serializer';
+import UnityVersioning from '../../unity-versioning';
+import { Cli } from '../../cli/cli';
+import CloudRunnerOptions from '../cloud-runner-options';
+import GitHub from '../../github';
+import setups from './cloud-runner-suite.test';
+
+async function CreateParameters(overrides) {
+  if (overrides) {
+    Cli.options = overrides;
+  }
+  const originalValue = GitHub.githubInputEnabled;
+  GitHub.githubInputEnabled = false;
+  const results = await BuildParameters.create();
+  GitHub.githubInputEnabled = originalValue;
+  delete Cli.options;
+
+  return results;
+}
+describe('Cloud Runner Environment Serializer', () => {
+  setups();
+  const testSecretName = 'testSecretName';
+  const testSecretValue = 'testSecretValue';
+  it('Responds', () => {});
+
+  if (CloudRunnerOptions.cloudRunnerTests) {
+    it('Task parameters serialize correctly', async () => {
+      // Setup parameters
+      const buildParameter = await CreateParameters({
+        versioning: 'None',
+        projectPath: 'test-project',
+        unityVersion: UnityVersioning.read('test-project'),
+        targetPlatform: 'StandaloneLinux64',
+        customJob: `
+        - name: 'step 1'
+          image: 'alpine'
+          commands: 'printenv'
+          secrets:
+            - name: '${testSecretName}'
+              value: '${testSecretValue}'
+        `,
+      });
+
+      const result = TaskParameterSerializer.readBuildParameters([], buildParameter);
+      expect(result.find((x) => Number.parseInt(x)) === undefined).toBeFalsy;
+    });
+  }
+});

src/model/cloud-runner/tests/cloud-runner-sync-environment.test.ts

@@ -22,33 +22,13 @@ async function CreateParameters(overrides) {
 
   return results;
 }
-describe('Cloud Runner  Sync Environments', () => {
+describe('Cloud Runner Sync Environments', () => {
   setups();
   const testSecretName = 'testSecretName';
   const testSecretValue = 'testSecretValue';
   it('Responds', () => {});
 
   if (CloudRunnerOptions.cloudRunnerTests) {
-    it('Task parameters serialize correctly', async () => {
-      // Setup parameters
-      const buildParameter = await CreateParameters({
-        versioning: 'None',
-        projectPath: 'test-project',
-        unityVersion: UnityVersioning.read('test-project'),
-        targetPlatform: 'StandaloneLinux64',
-        customJob: `
-        - name: 'step 1'
-          image: 'alpine'
-          commands: 'printenv'
-          secrets:
-            - name: '${testSecretName}'
-              value: '${testSecretValue}'
-        `,
-      });
-
-      TaskParameterSerializer.readBuildParameters([], buildParameter);
-    });
-
     it('All build parameters sent to cloud runner as env vars', async () => {
       // Setup parameters
       const buildParameter = await CreateParameters({

src/model/cloud-runner/workflows/build-automation-workflow.ts

@@ -46,8 +46,8 @@ export class BuildAutomationWorkflow implements WorkflowInterface {
         BuildAutomationWorkflow.BuildWorkflow,
         `/${CloudRunnerFolders.buildVolumeFolder}`,
         `/${CloudRunnerFolders.buildVolumeFolder}/`,
-        [...CloudRunner.cloudRunnerEnvironmentVariables, ...cloudRunnerStepState.environment],
+        cloudRunnerStepState.environment,
-        [...CloudRunner.defaultSecrets, ...cloudRunnerStepState.secrets],
+        cloudRunnerStepState.secrets,
       );
       if (!CloudRunner.buildParameters.isCliMode) core.endGroup();
       CloudRunnerLogger.logWithTime('Build time');