actions
/
unity-builder
mirror of https://github.com/game-ci/unity-builder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

filter out empty secret env vars

pull/289/head
Frostebite 2021-08-15 18:13:15 +00:00 committed by GitHub
parent ec239aa2e7
commit 589eed6f71
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dist/index.js vendored
View File

@ -966,6 +966,9 @@ class AWSBuildEnvironment {
const cleanupCloudFormation = fs.readFileSync(`${__dirname}/cloud-formations/cloudformation-stack-ttl.yml`, 'utf8'); const cleanupCloudFormation = fs.readFileSync(`${__dirname}/cloud-formations/cloudformation-stack-ttl.yml`, 'utf8');
try { try {
for (const secret of secrets) { for (const secret of secrets) {
if (!secret.ParameterValue || secret.ParameterValue === '') {
continue;
}
taskDefCloudFormation = this.insertAtTemplate(taskDefCloudFormation, 'p1 - input', this.getParameterTemplate(secret.ParameterKey.replace(/[^\dA-Za-z]/g, ''))); taskDefCloudFormation = this.insertAtTemplate(taskDefCloudFormation, 'p1 - input', this.getParameterTemplate(secret.ParameterKey.replace(/[^\dA-Za-z]/g, '')));
taskDefCloudFormation = this.insertAtTemplate(taskDefCloudFormation, 'p2 - secret', this.getSecretTemplate(secret.ParameterKey.replace(/[^\dA-Za-z]/g, ''))); taskDefCloudFormation = this.insertAtTemplate(taskDefCloudFormation, 'p2 - secret', this.getSecretTemplate(secret.ParameterKey.replace(/[^\dA-Za-z]/g, '')));
taskDefCloudFormation = this.insertAtTemplate(taskDefCloudFormation, 'p3 - container def', this.getSecretDefinitionTemplate(secret.EnvironmentVariable, secret.ParameterKey.replace(/[^\dA-Za-z]/g, ''))); taskDefCloudFormation = this.insertAtTemplate(taskDefCloudFormation, 'p3 - container def', this.getSecretDefinitionTemplate(secret.EnvironmentVariable, secret.ParameterKey.replace(/[^\dA-Za-z]/g, '')));

2
dist/index.js.map vendored
View File

File diff suppressed because one or more lines are too long

3
src/model/remote-builder/aws-build-platform.ts
View File

@ -121,6 +121,9 @@ class AWSBuildEnvironment implements RemoteBuilderProviderInterface {
try { try {
for (const secret of secrets) { for (const secret of secrets) {
if (!secret.ParameterValue || secret.ParameterValue === '') {
continue;
}
taskDefCloudFormation = this.insertAtTemplate( taskDefCloudFormation = this.insertAtTemplate(
taskDefCloudFormation, taskDefCloudFormation,
'p1 - input', 'p1 - input',