Do not include all env vars as secrets!

pull/461/head
Frostebite 2022-09-17 06:30:51 +01:00
parent a330d4e9a3
commit 6daf32f531
3 changed files with 29 additions and 25 deletions

24
dist/index.js vendored
View File

@ -4628,12 +4628,12 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
}; };
Object.defineProperty(exports, "__esModule", ({ value: true })); Object.defineProperty(exports, "__esModule", ({ value: true }));
exports.TaskParameterSerializer = void 0; exports.TaskParameterSerializer = void 0;
const cloud_runner_1 = __importDefault(__nccwpck_require__(79144));
const __1 = __nccwpck_require__(41359); const __1 = __nccwpck_require__(41359);
const image_environment_factory_1 = __importDefault(__nccwpck_require__(25145));
const cloud_runner_custom_hooks_1 = __nccwpck_require__(58873); const cloud_runner_custom_hooks_1 = __nccwpck_require__(58873);
const cloud_runner_query_override_1 = __importDefault(__nccwpck_require__(31011)); const cloud_runner_query_override_1 = __importDefault(__nccwpck_require__(31011));
const cloud_runner_options_reader_1 = __importDefault(__nccwpck_require__(3343)); const cloud_runner_options_reader_1 = __importDefault(__nccwpck_require__(3343));
// import CloudRunner from '../cloud-runner';
// import ImageEnvironmentFactory from '../../image-environment-factory';
class TaskParameterSerializer { class TaskParameterSerializer {
static readBuildEnvironmentVariables(buildParameters) { static readBuildEnvironmentVariables(buildParameters) {
return [ return [
@ -4699,15 +4699,17 @@ class TaskParameterSerializer {
array = TaskParameterSerializer.tryAddInput(array, 'UNITY_SERIAL'); array = TaskParameterSerializer.tryAddInput(array, 'UNITY_SERIAL');
array = TaskParameterSerializer.tryAddInput(array, 'UNITY_EMAIL'); array = TaskParameterSerializer.tryAddInput(array, 'UNITY_EMAIL');
array = TaskParameterSerializer.tryAddInput(array, 'UNITY_PASSWORD'); array = TaskParameterSerializer.tryAddInput(array, 'UNITY_PASSWORD');
array.push(...image_environment_factory_1.default.getEnvironmentVariables(cloud_runner_1.default.buildParameters) // array.push(
.filter((x) => array.every((y) => y.ParameterKey !== x.name)) // ...ImageEnvironmentFactory.getEnvironmentVariables(CloudRunner.buildParameters)
.map((x) => { // .filter((x) => array.every((y) => y.ParameterKey !== x.name))
return { // .map((x) => {
ParameterKey: x.name, // return {
EnvironmentVariable: x.name, // ParameterKey: x.name,
ParameterValue: x.value, // EnvironmentVariable: x.name,
}; // ParameterValue: x.value,
})); // };
// }),
// );
return array; return array;
} }
static getValue(key) { static getValue(key) {

2
dist/index.js.map vendored

File diff suppressed because one or more lines are too long

View File

@ -1,6 +1,4 @@
import CloudRunner from '../cloud-runner';
import { Input } from '../..'; import { Input } from '../..';
import ImageEnvironmentFactory from '../../image-environment-factory';
import CloudRunnerEnvironmentVariable from './cloud-runner-environment-variable'; import CloudRunnerEnvironmentVariable from './cloud-runner-environment-variable';
import { CloudRunnerCustomHooks } from './cloud-runner-custom-hooks'; import { CloudRunnerCustomHooks } from './cloud-runner-custom-hooks';
import CloudRunnerSecret from './cloud-runner-secret'; import CloudRunnerSecret from './cloud-runner-secret';
@ -8,6 +6,9 @@ import CloudRunnerQueryOverride from './cloud-runner-query-override';
import CloudRunnerOptionsReader from './cloud-runner-options-reader'; import CloudRunnerOptionsReader from './cloud-runner-options-reader';
import BuildParameters from '../../build-parameters'; import BuildParameters from '../../build-parameters';
// import CloudRunner from '../cloud-runner';
// import ImageEnvironmentFactory from '../../image-environment-factory';
export class TaskParameterSerializer { export class TaskParameterSerializer {
public static readBuildEnvironmentVariables(buildParameters: BuildParameters): CloudRunnerEnvironmentVariable[] { public static readBuildEnvironmentVariables(buildParameters: BuildParameters): CloudRunnerEnvironmentVariable[] {
return [ return [
@ -82,17 +83,18 @@ export class TaskParameterSerializer {
array = TaskParameterSerializer.tryAddInput(array, 'UNITY_SERIAL'); array = TaskParameterSerializer.tryAddInput(array, 'UNITY_SERIAL');
array = TaskParameterSerializer.tryAddInput(array, 'UNITY_EMAIL'); array = TaskParameterSerializer.tryAddInput(array, 'UNITY_EMAIL');
array = TaskParameterSerializer.tryAddInput(array, 'UNITY_PASSWORD'); array = TaskParameterSerializer.tryAddInput(array, 'UNITY_PASSWORD');
array.push(
...ImageEnvironmentFactory.getEnvironmentVariables(CloudRunner.buildParameters) // array.push(
.filter((x) => array.every((y) => y.ParameterKey !== x.name)) // ...ImageEnvironmentFactory.getEnvironmentVariables(CloudRunner.buildParameters)
.map((x) => { // .filter((x) => array.every((y) => y.ParameterKey !== x.name))
return { // .map((x) => {
ParameterKey: x.name, // return {
EnvironmentVariable: x.name, // ParameterKey: x.name,
ParameterValue: x.value, // EnvironmentVariable: x.name,
}; // ParameterValue: x.value,
}), // };
); // }),
// );
return array; return array;
} }