Further improve missing email and password error. Remove temppaths being mounted to docker image

pull/305/head
Andrew Kahr 2022-01-23 21:04:47 -08:00
parent d6cc7fd22f
commit 9b1ea18e4a
3 changed files with 7 additions and 9 deletions

7
dist/index.js vendored
View File

@ -441,8 +441,9 @@ class Docker {
unitySerial = process.env.UNITY_SERIAL;
}
if (!(process.env.UNITY_EMAIL && process.env.UNITY_PASSWORD)) {
throw new Error(`Unity email and password must be set for Windows based builds. Make
sure to set them inside UNITY_EMAIL and UNITY_PASSWORD in Github Secrets.`);
throw new Error(`Unity email and password must be set for Windows based builds to
authenticate the license. Make sure to set them inside UNITY_EMAIL
and UNITY_PASSWORD in Github Secrets and pass them into the environment.`);
}
yield this.setupWindowsRun(platform);
this.validateWindowsPlatformRequirements(platform);
@ -489,8 +490,6 @@ class Docker {
--env RUNNER_TEMP \
--env RUNNER_WORKSPACE \
--env GIT_PRIVATE_TOKEN="${gitPrivateToken}" \
--volume "${runnerTempPath}/_github_home":"c:/root" \
--volume "${runnerTempPath}/_github_workflow":"c:/github/workflow" \
--volume "${workspace}":"c:/github/workspace" \
--volume "c:/regkeys":"c:/regkeys" \
--volume "C:/Program Files (x86)/Microsoft Visual Studio":"C:/Program Files (x86)/Microsoft Visual Studio" \

2
dist/index.js.map vendored

File diff suppressed because one or more lines are too long

View File

@ -117,8 +117,9 @@ class Docker {
}
if (!(process.env.UNITY_EMAIL && process.env.UNITY_PASSWORD)) {
throw new Error(`Unity email and password must be set for Windows based builds. Make
sure to set them inside UNITY_EMAIL and UNITY_PASSWORD in Github Secrets.`);
throw new Error(`Unity email and password must be set for Windows based builds to
authenticate the license. Make sure to set them inside UNITY_EMAIL
and UNITY_PASSWORD in Github Secrets and pass them into the environment.`);
}
await this.setupWindowsRun(platform);
@ -168,8 +169,6 @@ class Docker {
--env RUNNER_TEMP \
--env RUNNER_WORKSPACE \
--env GIT_PRIVATE_TOKEN="${gitPrivateToken}" \
--volume "${runnerTempPath}/_github_home":"c:/root" \
--volume "${runnerTempPath}/_github_workflow":"c:/github/workflow" \
--volume "${workspace}":"c:/github/workspace" \
--volume "c:/regkeys":"c:/regkeys" \
--volume "C:/Program Files (x86)/Microsoft Visual Studio":"C:/Program Files (x86)/Microsoft Visual Studio" \