actions
/
unity-builder
mirror of https://github.com/game-ci/unity-builder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix

pull/531/head
Frostebite 2024-01-27 12:51:35 +00:00
parent 71f94af18c
commit aaeb1d1947
12 changed files with 66 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
dist/index.js generated vendored
View File

@ -829,7 +829,7 @@ class CloudRunner {
}
await CloudRunner.updateStatusWithBuildParameters();
const output = await new workflow_composition_root_1.WorkflowCompositionRoot().run(new cloud_runner_step_parameters_1.CloudRunnerStepParameters(baseImage, CloudRunner.cloudRunnerEnvironmentVariables, CloudRunner.defaultSecrets));
await CloudRunner.Provider.cleanupWorkflow(CloudRunner.buildParameters.buildGuid, CloudRunner.buildParameters, CloudRunner.buildParameters.branch, CloudRunner.defaultSecrets);
await CloudRunner.Provider.cleanupWorkflow(CloudRunner.buildParameters, CloudRunner.buildParameters.branch, CloudRunner.defaultSecrets);
if (!CloudRunner.buildParameters.isCliMode)
core.endGroup();
if ((buildParameters.asyncWorkflow && this.isCloudRunnerEnvironment) || !buildParameters.asyncWorkflow) {
@ -917,7 +917,7 @@ class CloudRunnerError {
cloud_runner_logger_1.default.error(JSON.stringify(error, undefined, 4));
core.setFailed('Cloud Runner failed');
if (cloud_runner_1.default.Provider !== undefined) {
await cloud_runner_1.default.Provider.cleanupWorkflow(buildParameters.buildGuid, buildParameters, buildParameters.branch, secrets);
await cloud_runner_1.default.Provider.cleanupWorkflow(buildParameters, buildParameters.branch, secrets);
}
}
}
@ -2877,8 +2877,6 @@ class AWSBuildEnvironment {
}
async cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid,
// eslint-disable-next-line no-unused-vars
buildParameters,
// eslint-disable-next-line no-unused-vars
branchName,
@ -3231,7 +3229,7 @@ class LocalDockerCloudRunner {
baseDependencies) {
return new Promise((result) => result(``));
}
async cleanupWorkflow(buildGuid, buildParameters,
async cleanupWorkflow(buildParameters,
// eslint-disable-next-line no-unused-vars
branchName,
// eslint-disable-next-line no-unused-vars
@ -3559,7 +3557,7 @@ class Kubernetes {
cloud_runner_logger_1.default.log('cleaned up Secret, Job and Pod');
cloud_runner_logger_1.default.log('cleaning up finished');
}
async cleanupWorkflow(buildGuid, buildParameters,
async cleanupWorkflow(buildParameters,
// eslint-disable-next-line no-unused-vars
branchName,
// eslint-disable-next-line no-unused-vars
@ -4193,8 +4191,6 @@ class LocalCloudRunner {
}
cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid,
// eslint-disable-next-line no-unused-vars
buildParameters,
// eslint-disable-next-line no-unused-vars
branchName,
@ -4258,8 +4254,6 @@ class TestCloudRunner {
}
cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid,
// eslint-disable-next-line no-unused-vars
buildParameters,
// eslint-disable-next-line no-unused-vars
branchName,
@ -6384,9 +6378,10 @@ class GitHub {
}
static async triggerWorkflowOnComplete(triggerWorkflowOnComplete) {
const isLocalAsync = cloud_runner_1.default.buildParameters.asyncWorkflow && !cloud_runner_1.default.isCloudRunnerAsyncEnvironment;
if (isLocalAsync) {
if (isLocalAsync || triggerWorkflowOnComplete === undefined || triggerWorkflowOnComplete.length === 0) {
return;
}
try {
const workflowsResult = await GitHub.octokitPAT.request(`GET /repos/{owner}/{repo}/actions/workflows`, {
owner: GitHub.owner,
repo: GitHub.repo,
@ -6416,6 +6411,10 @@ class GitHub {
});
}
}
catch {
core.info(`github workflow complete hook not found`);
}
}
}
GitHub.asyncChecksApiWorkflowName = `Async Checks API`;
GitHub.githubInputEnabled = true;

2
dist/index.js.map generated vendored
View File

File diff suppressed because one or more lines are too long

1
src/model/cloud-runner/cloud-runner.ts
View File

@ -125,7 +125,6 @@ class CloudRunner {
),
);
await CloudRunner.Provider.cleanupWorkflow(
CloudRunner.buildParameters.buildGuid,
CloudRunner.buildParameters,
CloudRunner.buildParameters.branch,
CloudRunner.defaultSecrets,

7
src/model/cloud-runner/error/cloud-runner-error.ts
View File

@ -9,12 +9,7 @@ export class CloudRunnerError {
CloudRunnerLogger.error(JSON.stringify(error, undefined, 4));
core.setFailed('Cloud Runner failed');
if (CloudRunner.Provider !== undefined) {
await CloudRunner.Provider.cleanupWorkflow(
buildParameters.buildGuid,
buildParameters,
buildParameters.branch,
secrets,
);
await CloudRunner.Provider.cleanupWorkflow(buildParameters, buildParameters.branch, secrets);
}
}
}

2
src/model/cloud-runner/providers/aws/index.ts
View File

@ -57,8 +57,6 @@ class AWSBuildEnvironment implements ProviderInterface {
}
async cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid: string,
// eslint-disable-next-line no-unused-vars
buildParameters: BuildParameters,
// eslint-disable-next-line no-unused-vars

1
src/model/cloud-runner/providers/docker/index.ts
View File

@ -41,7 +41,6 @@ class LocalDockerCloudRunner implements ProviderInterface {
return new Promise((result) => result(``));
}
async cleanupWorkflow(
buildGuid: string,
buildParameters: BuildParameters,
// eslint-disable-next-line no-unused-vars
branchName: string,

1
src/model/cloud-runner/providers/k8s/index.ts
View File

@ -306,7 +306,6 @@ class Kubernetes implements ProviderInterface {
}
async cleanupWorkflow(
buildGuid: string,
buildParameters: BuildParameters,
// eslint-disable-next-line no-unused-vars
branchName: string,

2
src/model/cloud-runner/providers/local/index.ts
View File

@ -32,8 +32,6 @@ class LocalCloudRunner implements ProviderInterface {
throw new Error('Method not implemented.');
}
cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid: string,
// eslint-disable-next-line no-unused-vars
buildParameters: BuildParameters,
// eslint-disable-next-line no-unused-vars

2
src/model/cloud-runner/providers/provider-interface.ts
View File

@ -6,8 +6,6 @@ import { ProviderWorkflow } from './provider-workflow';
export interface ProviderInterface {
cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid: string,
// eslint-disable-next-line no-unused-vars
buildParameters: BuildParameters,
// eslint-disable-next-line no-unused-vars

2
src/model/cloud-runner/providers/test/index.ts
View File

@ -25,8 +25,6 @@ class TestCloudRunner implements ProviderInterface {
throw new Error('Method not implemented.');
}
cleanupWorkflow(
// eslint-disable-next-line no-unused-vars
buildGuid: string,
// eslint-disable-next-line no-unused-vars
buildParameters: BuildParameters,
// eslint-disable-next-line no-unused-vars

1
src/model/cloud-runner/tests/e2e/cloud-runner-end2end-caching.test.ts
View File

@ -30,6 +30,7 @@ describe('Cloud Runner Caching', () => {
targetPlatform: 'StandaloneLinux64',
cacheKey: `test-case-${uuidv4()}`,
containerHookFiles: `debug-cache`,
cloudRunnerBranch: `cloud-runner-develop`,
};
if (CloudRunnerOptions.providerStrategy === `k8s`) {
overrides.containerHookFiles += `,aws-s3-pull-cache,aws-s3-upload-cache`;

6
src/model/github.ts
View File

@ -175,9 +175,10 @@ class GitHub {
static async triggerWorkflowOnComplete(triggerWorkflowOnComplete: string[]) {
const isLocalAsync = CloudRunner.buildParameters.asyncWorkflow && !CloudRunner.isCloudRunnerAsyncEnvironment;
if (isLocalAsync) {
if (isLocalAsync || triggerWorkflowOnComplete === undefined || triggerWorkflowOnComplete.length === 0) {
return;
}
try {
const workflowsResult = await GitHub.octokitPAT.request(`GET /repos/{owner}/{repo}/actions/workflows`, {
owner: GitHub.owner,
repo: GitHub.repo,
@ -206,6 +207,9 @@ class GitHub {
},
});
}
} catch {
core.info(`github workflow complete hook not found`);
}
}
}