From 02c0e7b60c16f758ec6e32b9359acd8c04ffd58c Mon Sep 17 00:00:00 2001 From: Paul Pacheco Date: Sat, 25 Sep 2021 14:36:17 -0500 Subject: [PATCH] fix unary operator expected error (#146) * fix unary operator expected error The if comparisons can sometimes compare an empty variable, which gives errors like this: ``` /steps/run_tests.sh: line 71: [: =: unary operator expected ``` This PR should fix the script to address that problem. See an explanation of why this error happens here: https://codefather.tech/blog/bash-unary-operator-expected/ * fix missing quote * Posix shell compliance Posix shell does not do ==, it only does one = * consistent spaces --- action/steps/run_tests.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/action/steps/run_tests.sh b/action/steps/run_tests.sh index 36be50e..f0646ef 100644 --- a/action/steps/run_tests.sh +++ b/action/steps/run_tests.sh @@ -67,8 +67,8 @@ ls -alh $UNITY_PROJECT_PATH # # Testing in EditMode # - -if [ $EDIT_MODE = true ]; then +EDIT_MODE_EXIT_CODE=0 +if [ "$EDIT_MODE" = "true" ]; then echo "" echo "###########################" echo "# Testing in EditMode #" @@ -104,8 +104,8 @@ fi # # Testing in PlayMode # - -if [ $PLAY_MODE = true ]; then +PLAY_MODE_EXIT_CODE=0 +if [ "$PLAY_MODE" = "true" ]; then echo "" echo "###########################" echo "# Testing in PlayMode #" @@ -149,7 +149,7 @@ echo "###########################" echo "" ls -alh $UNITY_PROJECT_PATH -if [ $EDIT_MODE = true ]; then +if [ "$EDIT_MODE" = "true" ]; then echo "" echo "###########################" echo "# Edit Mode Results #" @@ -159,7 +159,7 @@ if [ $EDIT_MODE = true ]; then cat "$FULL_ARTIFACTS_PATH/editmode-results.xml" | grep test-run | grep Passed fi -if [ $PLAY_MODE = true ]; then +if [ "$PLAY_MODE" = "true" ]; then echo "" echo "###########################" echo "# Play Mode Results #"